Skip to content

Fix/mpu6050 missing "esp_driver_gpio" dependency (BSP-735) #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/mpu6050 missing "esp_driver_gpio" dependency (BSP-735) #672

wants to merge 3 commits into from

Conversation

@tommaso-merlini
Copy link

@tommaso-merlini tommaso-merlini commented Nov 5, 2025 •
edited by espzav
Loading

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

Component

mpu6050

Issue

The mpu6050.h header includes <driver/gpio.h>, which is provided by the esp_driver_gpio component. However, esp_driver_gpio was not declared in the component's dependencies.

This triggers a build error when inlcuding the library via idf.py add-dependency "espressif/mpu6050^1.1.1":

Compilation failed because mpu6050.h (in "espressif__mpu6050" component) includes driver/gpio.h, provided by esp_driver_gpio component(s).
However, esp_driver_gpio component(s) is not in the requirements list of "espressif__mpu6050".
To fix this, add esp_driver_gpio to PRIV_REQUIRES list of idf_component_register call in /home/tommaso/Documents/idf-esp-project/managed_components/espressif__mpu6050/CMakeLists.txt.
   19 | #include "driver/gpio.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.

Note

Declare missing esp_driver_gpio (and esp_driver_i2c) dependencies for IDF >= 5.3 in CMake and bump component version to 1.2.1.

  • mpu6050 component:
    • Build config: Conditionally set REQUIRES to esp_driver_gpio esp_driver_i2c for IDF >= 5.3; fallback to driver otherwise.
    • Version: Bump version to 1.2.1 in idf_component.yml.

Written by Cursor Bugbot for commit 445a95d. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings November 5, 2025 10:03
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cursor[bot]
cursor bot reviewed Nov 5, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

espzav
espzav reviewed Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget bump component version for release the component into component registry.

@github-actions github-actions bot changed the title Fix/mpu6050 missing "esp_driver_gpio" dependency Fix/mpu6050 missing "esp_driver_gpio" dependency (BSP-735) Nov 5, 2025
Copilot AI reviewed Nov 5, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a private dependency on the esp_driver_gpio component to the mpu6050 component's CMakeLists configuration.

  • Adds esp_driver_gpio as a private requirement to the mpu6050 component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tommaso-merlini tommaso-merlini force-pushed the fix/mpu6050-missing-gpio-dependency branch from 1907d32 to 591c966 Compare November 5, 2025 10:29
cursor[bot]
cursor bot reviewed Nov 5, 2025
View reviewed changes
@tommaso-merlini tommaso-merlini force-pushed the fix/mpu6050-missing-gpio-dependency branch 3 times, most recently from b1f26d6 to ddb6a86 Compare November 5, 2025 10:45
espzav
espzav reviewed Nov 5, 2025
View reviewed changes
@tommaso-merlini tommaso-merlini force-pushed the fix/mpu6050-missing-gpio-dependency branch from ddb6a86 to 77c58aa Compare November 5, 2025 10:50
@espzav espzav force-pushed the fix/mpu6050-missing-gpio-dependency branch from 5580775 to 445a95d Compare December 2, 2025 09:36
@espzav
Copy link
Collaborator

espzav commented Dec 2, 2025

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.✅ espzav❌ tommaso-merliniYou have signed the CLA already but the status is still pending? Let us recheck it.

@tommaso-merlini I updated your code and fixed it. Now it can be merge.
Please, could you sign the CLA. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@espzav espzav espzav left review comments

Copilot code review Copilot Copilot left review comments

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tommaso-merlini @CLAassistant @espzav